Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: 4622 - decouple out-of-band rendering from Fusion #3647

Merged
merged 5 commits into from
Oct 30, 2023
Merged

FEATURE: 4622 - decouple out-of-band rendering from Fusion #3647

merged 5 commits into from
Oct 30, 2023

Conversation

nezaniel
Copy link
Member

This allows users to use other views than Fusion for out-of-band-rendering

Requires neos/neos-development-collection#4635

@nezaniel nezaniel marked this pull request as draft October 20, 2023 23:30
@github-actions github-actions bot added the 9.0 label Oct 20, 2023
@nezaniel nezaniel marked this pull request as ready for review October 27, 2023 09:25
mficzel
mficzel requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move interface from neos/neos-development-collection#4635 here and extend Neos/Neos/FusionView

@nezaniel nezaniel changed the title 4622 - improved out-of-band rendering FEATURE: 4622 - decouple out-of-band rendering from Fusion Oct 30, 2023
@github-actions github-actions bot added the Feature Label to mark the change as feature label Oct 30, 2023
mhsdesign
mhsdesign approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks i like this ;)

@ahaeslich ahaeslich requested a review from mficzel October 30, 2023 13:03
ahaeslich
ahaeslich approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@ahaeslich ahaeslich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the current Neos.Demo

@nezaniel
Copy link
Member Author

Move interface from neos/neos-development-collection#4635 here and extend Neos/Neos/FusionView

done

@nezaniel nezaniel closed this Oct 30, 2023
@nezaniel nezaniel reopened this Oct 30, 2023
mficzel
mficzel approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by 👀

@mficzel mficzel merged commit 3aa32c1 into 9.0 Oct 30, 2023
6 checks passed
@mficzel mficzel deleted the 4622-outOfBandRendering branch October 30, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

@ahaeslich ahaeslich ahaeslich approved these changes

@mficzel mficzel mficzel approved these changes

@skurfuerst skurfuerst Awaiting requested review from skurfuerst

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

@kitsunet kitsunet Awaiting requested review from kitsunet

@grebaldi grebaldi Awaiting requested review from grebaldi

Assignees
No one assigned
Labels
9.0 Feature Label to mark the change as feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nezaniel @mficzel @ahaeslich @mhsdesign